Messages in this thread | | | Subject | Re: [PATCH 2/3] lkdtm/perms: Check possible NULL pointer returned by kmalloc(),vmalloc() | From | tury <> | Date | Tue, 26 Jul 2022 13:43:41 +0800 |
| |
在 2022年07月25日 20:37, Greg KH 写道: > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Mon, Jul 25, 2022 at 05:54:15PM +0800, tury wrote: >> When there is insufficient memory, the allocation will fail. > And have you ever seen that happen here? The issue is for small > allocations, they never will fail. > >> the return value is void,so i think it is ok . > Why? Because the function lkdtm_EXEC_KMALLOC() declaration is void,and The return value is not checked elsewhere. Should I add some warning messages? > >> should i have changed comment to something like this ? >> >> As the possible alloc failure of the kmalloc() and vmalloc(), >> the return pointer could be NULL.therefore it should be better to check it. > Please wrap your lines properly, and use '.' correctly. > > thanks, > > greg k-h Thank you for your help and patience, >
| |