Messages in this thread | | | Date | Wed, 27 Jul 2022 14:00:02 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 2/3] lkdtm/perms: Check possible NULL pointer returned by kmalloc(),vmalloc() |
| |
On Tue, Jul 26, 2022 at 01:43:41PM +0800, tury wrote: > 在 2022年07月25日 20:37, Greg KH 写道: > > A: http://en.wikipedia.org/wiki/Top_post > > Q: Were do I find info about this thing called top-posting? > > A: Because it messes up the order in which people normally read text. > > Q: Why is top-posting such a bad thing? > > A: Top-posting. > > Q: What is the most annoying thing in e-mail? > > > > A: No. > > Q: Should I include quotations after my reply? > > > > http://daringfireball.net/2007/07/on_top > > > > On Mon, Jul 25, 2022 at 05:54:15PM +0800, tury wrote: > > > When there is insufficient memory, the allocation will fail. > > And have you ever seen that happen here? The issue is for small > > allocations, they never will fail. > > > > > the return value is void,so i think it is ok . > > Why? > Because the function lkdtm_EXEC_KMALLOC() declaration is void,and The > return value is not checked elsewhere. > Should I add some warning messages?
Memory allocation failures will already be reported by the allocator, so there is normally no need for an additional message.
-- Kees Cook
| |