Messages in this thread | | | Date | Tue, 26 Jul 2022 09:48:21 +0200 | Subject | Re: [PATCH v5] watchdog: add driver for StreamLabs USB watchdog device | From | Oliver Neukum <> |
| |
On 26.07.22 02:21, Alexey Klimov wrote: > On Mon, Jul 25, 2022 at 9:51 AM Greg KH <gregkh@linuxfoundation.org> wrote: >> >> On Mon, Jul 25, 2022 at 04:06:05AM +0100, Alexey Klimov wrote: > > [..] > >> Anyway, driver looks good to me, nice work! >> >> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Thanks, Greg. If you don't mind I'll use your tag in next version > after making changes suggested by Guenter since there will be no > significant functional changes. If code will change a lot, then the > process (Documentation/process/submitting-patches.rst) will require me > to drop the tag.
Hi,
while thinking about this a question arose. How does this device react to a USB reset? A watchdog that can be disabled by a simple reset does not like very reliable to me. Do you need to implement pre/post_reset() ?
Regards Oliver
| |