Messages in this thread | | | Date | Mon, 25 Jul 2022 10:51:43 +0200 | From | Greg KH <> | Subject | Re: [PATCH v5] watchdog: add driver for StreamLabs USB watchdog device |
| |
On Mon, Jul 25, 2022 at 04:06:05AM +0100, Alexey Klimov wrote: > +static bool nowayout = WATCHDOG_NOWAYOUT; > +module_param(nowayout, bool, 0); > +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" > + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); > +
Meta-comment about watchdog drivers, this is per-driver, not per-device, which does not make sense for when these devices are on removable busses where you can have multiple ones.
I don't suggest changing this (as it follows the current style of other watchdog drivers), but perhaps a sysfs attribute for watchdog devices can do the same thing in the future so you can do this on a per-device basis.
Anyway, driver looks good to me, nice work!
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |