| From | Avri Altman <> | Subject | RE: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support | Date | Sun, 24 Jul 2022 07:21:42 +0000 |
| |
> +void ufshcd_mcq_config_mac(struct ufs_hba *hba) > +{ > + u32 val = ufshcd_readl(hba, REG_UFS_MCQ_CFG); > + > + val &= ~MCQ_CFG_MAC_MASK; > + val |= hba->dev_info.bqueuedepth << MCQ_CFG_MAC_OFFSET; > + ufshcd_writel(hba, val, REG_UFS_MCQ_CFG); > +} > +EXPORT_SYMBOL_GPL(ufshcd_mcq_config_mac); Arbitration scheme is something that I would expect to be configurable. Or at least, add a comment explicitly saying that you choose a round-robin arbitration scheme.
Thanks, Avri
|