lkml.org 
[lkml]   [2022]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next v3 27/47] net: fman: Inline several functions into initialization
Date
> -----Original Message-----
> From: Sean Anderson <sean.anderson@seco.com>
> Sent: Thursday, July 21, 2022 18:34
> To: Camelia Alexandra Groza <camelia.groza@nxp.com>; David S . Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Madalin Bucur
> <madalin.bucur@nxp.com>; netdev@vger.kernel.org
> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v3 27/47] net: fman: Inline several functions
> into initialization
>
>
>
> On 7/21/22 9:01 AM, Camelia Alexandra Groza wrote:
> >> -----Original Message-----
> >> From: Sean Anderson <sean.anderson@seco.com>
> >> Sent: Saturday, July 16, 2022 1:00
> >> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
> >> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
> >> netdev@vger.kernel.org
> >> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
> >> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
> >> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean
> Anderson
> >> <sean.anderson@seco.com>
> >> Subject: [PATCH net-next v3 27/47] net: fman: Inline several functions
> into
> >> initialization
> >>
> >> There are several small functions which weer only necessary because the
> >
> > *were* typo.
>
> Hm, I thought commit messages were supposed to be written as if the patch
> hadn't
> yet been applied (e.g. the current state as the patch is reviewed).

That's my understanding as well. I was pointing out this bit: "which weer only necessary ".
I assume you wanted to type "were" here.

> >> initialization functions didn't have access to the mac private data. Now
> >> that they do, just do things directly.
> >>
> >> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> >
> > Acked-by: Camelia Groza <camelia.groza@nxp.com>
> >
\
 
 \ /
  Last update: 2022-07-22 14:30    [W:0.366 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site