Messages in this thread | | | Subject | Re: [PATCH net-next v3 27/47] net: fman: Inline several functions into initialization | From | Sean Anderson <> | Date | Thu, 21 Jul 2022 11:33:34 -0400 |
| |
On 7/21/22 9:01 AM, Camelia Alexandra Groza wrote: >> -----Original Message----- >> From: Sean Anderson <sean.anderson@seco.com> >> Sent: Saturday, July 16, 2022 1:00 >> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski >> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>; >> netdev@vger.kernel.org >> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet >> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell >> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson >> <sean.anderson@seco.com> >> Subject: [PATCH net-next v3 27/47] net: fman: Inline several functions into >> initialization >> >> There are several small functions which weer only necessary because the > > *were* typo.
Hm, I thought commit messages were supposed to be written as if the patch hadn't yet been applied (e.g. the current state as the patch is reviewed).
--Sean
>> initialization functions didn't have access to the mac private data. Now >> that they do, just do things directly. >> >> Signed-off-by: Sean Anderson <sean.anderson@seco.com> > > Acked-by: Camelia Groza <camelia.groza@nxp.com> >
| |