lkml.org 
[lkml]   [2022]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 10/11] net: phy: aquantia: Add some additional phy interfaces
On Tue, Jul 19, 2022 at 07:50:00PM -0400, Sean Anderson wrote:
> +/* The following registers all have similar layouts; first the registers... */
> +#define VEND1_GLOBAL_CFG_10M 0x0310
> +#define VEND1_GLOBAL_CFG_100M 0x031b
> +#define VEND1_GLOBAL_CFG_1G 0x031c
> +#define VEND1_GLOBAL_CFG_2_5G 0x031d
> +#define VEND1_GLOBAL_CFG_5G 0x031e
> +#define VEND1_GLOBAL_CFG_10G 0x031f
> +/* ...and now the fields */
> +#define VEND1_GLOBAL_CFG_RATE_ADAPT GENMASK(8, 7)
> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_NONE 0
> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_USX 1
> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_PAUSE 2
> +

Shouldn't these definitions be in patch 11? They don't appear to be used
in this patch.

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

\
 
 \ /
  Last update: 2022-07-20 13:35    [W:0.479 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site