Messages in this thread | | | Subject | Re: [PATCH v2 10/11] net: phy: aquantia: Add some additional phy interfaces | From | Sean Anderson <> | Date | Thu, 21 Jul 2022 13:15:54 -0400 |
| |
On 7/20/22 7:35 AM, Russell King (Oracle) wrote: > On Tue, Jul 19, 2022 at 07:50:00PM -0400, Sean Anderson wrote: >> +/* The following registers all have similar layouts; first the registers... */ >> +#define VEND1_GLOBAL_CFG_10M 0x0310 >> +#define VEND1_GLOBAL_CFG_100M 0x031b >> +#define VEND1_GLOBAL_CFG_1G 0x031c >> +#define VEND1_GLOBAL_CFG_2_5G 0x031d >> +#define VEND1_GLOBAL_CFG_5G 0x031e >> +#define VEND1_GLOBAL_CFG_10G 0x031f >> +/* ...and now the fields */ >> +#define VEND1_GLOBAL_CFG_RATE_ADAPT GENMASK(8, 7) >> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_NONE 0 >> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_USX 1 >> +#define VEND1_GLOBAL_CFG_RATE_ADAPT_PAUSE 2 >> + > > Shouldn't these definitions be in patch 11? They don't appear to be used > in this patch.
You're right. It looks like I added these too early.
--Sean
| |