Messages in this thread | | | Date | Wed, 20 Jul 2022 13:33:28 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] kernel/sched/cputime: Fix unused value in cputime_adjust() |
| |
On Wed, Jul 20, 2022 at 06:29:56PM +0800, zengjx95@gmail.com wrote: > From: Zeng Jingxiang <linuszeng@tencent.com> > > Coverity warns uf an unused value: > > assigned_value: Assign the value of the variable rtime to utime here, > but that stored value is overwritten before it can be used. > 568 if (stime == 0) { > 569 utime = rtime; > 570 goto update; > 571 } > > value_overwrite: Overwriting previous write to utime with > the value of expression rtime - stime. > 592 utime = rtime - stime;
Coverity is being daft, the compiler has a dead-store-elimination pass.
This way the code is more consistent / easier to ready.
| |