lkml.org 
[lkml]   [2022]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] kernel/sched/cputime: Fix unused value in cputime_adjust()
Date
From: Zeng Jingxiang <linuszeng@tencent.com>

Coverity warns uf an unused value:

assigned_value: Assign the value of the variable rtime to utime here,
but that stored value is overwritten before it can be used.
568 if (stime == 0) {
569 utime = rtime;
570 goto update;
571 }

value_overwrite: Overwriting previous write to utime with
the value of expression rtime - stime.
592 utime = rtime - stime;

Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
---
kernel/sched/cputime.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index 78a233d43757..531df8b29e6d 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -565,10 +565,8 @@ void cputime_adjust(struct task_cputime *curr, struct prev_cputime *prev,
* Once a task gets some ticks, the monotonicity code at 'update:'
* will ensure things converge to the observed ratio.
*/
- if (stime == 0) {
- utime = rtime;
+ if (stime == 0)
goto update;
- }

if (utime == 0) {
stime = rtime;
--
2.27.0
\
 
 \ /
  Last update: 2022-07-20 12:31    [W:0.041 / U:3.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site