Messages in this thread |  | | Date | Mon, 18 Jul 2022 14:39:15 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: rtl8192u: fix rmmod warn when wlan0 is renamed |
| |
On Sun, Jul 17, 2022 at 12:01:57AM -0700, Tong Zhang wrote: > There are 4 debug files created under /proc/net/[Devname]. Devname could > be wlan0 initially, however it could be renamed later to e.g. enx00e04c000002. > This will cause problem during debug file teardown since it uses > netdev->name which is no longer wlan0. To solve this problem, add a > notifier to handle device renaming. > > Also, due to this is purely for debuging as files are created read only, > move this to debugfs like other NIC drivers do instead of using procfs. >
You're doing too many things in one patch. Maybe do it like this: patch 1: Move the functions (no functional change). patch 2: Change to debugfs instead of procfs patch 3: Add the notifier
regards, dan carpenter
|  |