lkml.org 
[lkml]   [2022]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] usb: dwc3: qcom: fix missing optional irq warnings
On Wed, Jul 13, 2022 at 03:13:36PM +0200, Johan Hovold wrote:
> Not all platforms have all of the four currently supported wakeup
> interrupts so use the optional irq helpers when looking up interrupts to
> avoid printing error messages when an optional interrupt is not found:
>
> dwc3-qcom a6f8800.usb: error -ENXIO: IRQ hs_phy_irq not found
>
> Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 77036551987a..c5e482f53e9d 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -490,9 +490,9 @@ static int dwc3_qcom_get_irq(struct platform_device *pdev,
> int ret;
>
> if (np)
> - ret = platform_get_irq_byname(pdev_irq, name);
> + ret = platform_get_irq_byname_optional(pdev_irq, name);
> else
> - ret = platform_get_irq(pdev_irq, num);
> + ret = platform_get_irq_optional(pdev_irq, num);
>
> return ret;
> }
> --
> 2.35.1
>

Reviewed-by: Andrew Halaney <ahalaney@redhat.com>

\
 
 \ /
  Last update: 2022-07-13 16:00    [W:0.133 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site