Messages in this thread | | | From | Guenter Roeck <> | Date | Wed, 13 Jul 2022 11:18:32 -0700 | Subject | Re: [RESEND PATCH 07/11] platform/chrome: cros_ec_proto: return -EAGAIN when retries timed out |
| |
On Mon, Jun 27, 2022 at 7:49 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > While EC_COMMS_STATUS_PROCESSING flag is still on after it tries > EC_COMMAND_RETRIES times for sending EC_CMD_GET_COMMS_STATUS, > cros_ec_wait_until_complete() doesn't return an error code. > > Return -EAGAIN in the case instead.
Does this make sense, or should it be -ETIMEDOUT ? What does the EC do if it is still busy (stuck ?) with executing a command and it gets another one ?
> > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> > --- > drivers/platform/chrome/cros_ec_proto.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c > index 466ecb063bd6..49772a4c5353 100644 > --- a/drivers/platform/chrome/cros_ec_proto.c > +++ b/drivers/platform/chrome/cros_ec_proto.c > @@ -167,6 +167,9 @@ static int cros_ec_wait_until_complete(struct cros_ec_device *ec_dev, uint32_t * > break; > } > > + if (i >= EC_COMMAND_RETRIES) > + ret = -EAGAIN; > + > kfree(msg); > return ret; > } > -- > 2.37.0.rc0.161.g10f37bed90-goog >
| |