Messages in this thread |  | | From | Guenter Roeck <> | Date | Wed, 13 Jul 2022 11:16:21 -0700 | Subject | Re: [RESEND PATCH 06/11] platform/chrome: cros_ec_proto: change Kunit expectation when timed out |
| |
On Mon, Jun 27, 2022 at 7:49 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > While EC_COMMS_STATUS_PROCESSING flag is still on after it tries > EC_COMMAND_RETRIES times for sending EC_CMD_GET_COMMS_STATUS, > cros_ec_wait_until_complete() doesn't return an error code. > > Change the expectation to an error code. > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> --- > drivers/platform/chrome/cros_ec_proto_test.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c > index 64100fd81c6a..fbb872040711 100644 > --- a/drivers/platform/chrome/cros_ec_proto_test.c > +++ b/drivers/platform/chrome/cros_ec_proto_test.c > @@ -1870,9 +1870,7 @@ static void cros_ec_proto_test_cmd_xfer_in_progress_retries_status_processing(st > } > > ret = cros_ec_cmd_xfer(ec_dev, &msg); > - KUNIT_EXPECT_EQ(test, ret, sizeof(struct ec_response_get_comms_status)); > - > - KUNIT_EXPECT_EQ(test, msg.result, EC_RES_SUCCESS); > + KUNIT_EXPECT_EQ(test, ret, -EAGAIN); > > /* For EC_CMD_GET_COMMS_STATUS EC_COMMAND_RETRIES times. */ > KUNIT_EXPECT_EQ(test, cros_kunit_ec_pkt_xfer_mock_called, 51); > -- > 2.37.0.rc0.161.g10f37bed90-goog >
|  |