Messages in this thread | | | Date | Tue, 12 Jul 2022 18:09:06 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH v2,net-next] net/sched: remove return value of unregister_tcf_proto_ops |
| |
On Mon, 11 Jul 2022 16:09:10 +0800 Zhengchao Shao wrote: > Return value of unregister_tcf_proto_ops is unused, remove it.
> -int unregister_tcf_proto_ops(struct tcf_proto_ops *ops) > +void unregister_tcf_proto_ops(struct tcf_proto_ops *ops) > { > struct tcf_proto_ops *t; > int rc = -ENOENT; > @@ -214,7 +214,10 @@ int unregister_tcf_proto_ops(struct tcf_proto_ops *ops) > } > } > write_unlock(&cls_mod_lock); > - return rc; > +
> + if (rc) > + pr_warn("unregister tc filter kind(%s) failed\n", ops->kind);
I was saying WARN, by which I meant:
WARN(rc, "unregister tc filter kind(%s) failed %d\n", ops->kind, rc);
| |