Messages in this thread Patch in this message | | | From | shaozhengchao <> | Subject | 答复: [PATCH v2,net-next] net/sched: remove r eturn value of unregister tcf proto ops | Date | Wed, 13 Jul 2022 01:45:21 +0000 |
| |
-----邮件原件----- 发件人: Jakub Kicinski [mailto:kuba@kernel.org] 发送时间: 2022年7月13日 9:09 收件人: shaozhengchao <shaozhengchao@huawei.com> 抄送: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; jhs@mojatatu.com; xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; weiyongjun (A) <weiyongjun1@huawei.com>; yuehaibing <yuehaibing@huawei.com> 主题: Re: [PATCH v2,net-next] net/sched: remove return value of unregister_tcf_proto_ops
On Mon, 11 Jul 2022 16:09:10 +0800 Zhengchao Shao wrote: > Return value of unregister_tcf_proto_ops is unused, remove it.
> -int unregister_tcf_proto_ops(struct tcf_proto_ops *ops) > +void unregister_tcf_proto_ops(struct tcf_proto_ops *ops) > { > struct tcf_proto_ops *t; > int rc = -ENOENT; > @@ -214,7 +214,10 @@ int unregister_tcf_proto_ops(struct tcf_proto_ops *ops) > } > } > write_unlock(&cls_mod_lock); > - return rc; > +
> + if (rc) > + pr_warn("unregister tc filter kind(%s) failed\n", ops->kind);
I was saying WARN, by which I meant:
WARN(rc, "unregister tc filter kind(%s) failed %d\n", ops->kind, rc);
Hi Jakub: Thank you for your reply. I will fix it.
Zhangchao Shao
| |