Messages in this thread | | | From | Bernard Metzler <> | Subject | RE: [PATCH] RDMA: remove useless condition in siw_create_cq() | Date | Mon, 11 Jul 2022 16:21:41 +0000 |
| |
> -----Original Message----- > From: Andrey Strachuk <strochuk@ispras.ru> > Sent: Monday, 11 July 2022 17:13 > To: Bernard Metzler <BMT@zurich.ibm.com> > Cc: Andrey Strachuk <strochuk@ispras.ru>; Jason Gunthorpe <jgg@ziepe.ca>; > Leon Romanovsky <leon@kernel.org>; linux-rdma@vger.kernel.org; linux- > kernel@vger.kernel.org; ldv-project@linuxtesting.org > Subject: [EXTERNAL] [PATCH] RDMA: remove useless condition in > siw_create_cq() > > Comparison of 'cq' with NULL is useless since > 'cq' is a result of container_of and cannot be NULL > in any reasonable scenario. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Andrey Strachuk <strochuk@ispras.ru> > Fixes: 303ae1cdfdf7 ("rdma/siw: application interface") > --- > drivers/infiniband/sw/siw/siw_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/siw/siw_verbs.c > b/drivers/infiniband/sw/siw/siw_verbs.c > index 09316072b789..8dedae7ae79e 100644 > --- a/drivers/infiniband/sw/siw/siw_verbs.c > +++ b/drivers/infiniband/sw/siw/siw_verbs.c > @@ -1167,7 +1167,7 @@ int siw_create_cq(struct ib_cq *base_cq, const struct > ib_cq_init_attr *attr, > err_out: > siw_dbg(base_cq->device, "CQ creation failed: %d", rv); > > - if (cq && cq->queue) { > + if (cq->queue) { > struct siw_ucontext *ctx = > rdma_udata_to_drv_context(udata, struct siw_ucontext, > base_ucontext); > -- > 2.25.1
Acked-by: Bernard Metzler <bmt@zurich.ibm.com>
Thanks Andrey!
| |