lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema
Date
> > Convert the Atmel flexcom device tree bindings to json schema.
> >
> > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > ---
> > v1 -> v2:
> > - Fix title.
> >
> > .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++
> > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------
> > 2 files changed, 97 insertions(+), 63 deletions(-)
> > create mode 100644
> Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> flexcom.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> > new file mode 100644
> > index 000000000000..05cb6ebb4b2a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> > @@ -0,0 +1,97 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Atmel Flexcom (Flexible Serial Communication Unit)
> > +
> > +maintainers:
> > + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > +
> > +description:
> > + The Atmel Flexcom is just a wrapper which embeds a SPI controller,
> > + an I2C controller and an USART. Only one function can be used at a
> > + time and is chosen at boot time according to the device tree.
> > +
> > +properties:
> > + compatible:
> > + const: atmel,sama5d2-flexcom
>
> Same comment applies as before... Your previous set was better here and
> for some reason you decided to change it. This should be enum so you
> avoid useless change next patch.
>
Thanks for your comments.
Do you mean use "enum" instead of "const" in current patch itself and add new compatible in 2/3 patch?

> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 1
> > +
> > + ranges:
> > + description:
> > + One range for the full I/O register region. (including USART,
> > + TWI and SPI registers).
> > + items:
> > + maxItems: 3
> > +
> > + atmel,flexcom-mode:
> > + description: |
> > + Specifies the flexcom mode as follows:
> > + 1: USART
> > + 2: SPI
> > + 3: I2C.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [1, 2, 3]
> > +
> > +patternProperties:
> > + "^serial@[0-9a-f]+$":
> > + description: See atmel-usart.txt for details of USART bindings.
> > + type: object
> > +
> > + "^spi@[0-9a-f]+$":
> > + description: See ../spi/spi_atmel.txt for details of SPI bindings.
> > + type: object
> > +
> > + "^i2c@[0-9a-f]+$":
> > + description: See ../i2c/i2c-at91.txt for details of I2C bindings.
> > + type: object
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - "#address-cells"
> > + - "#size-cells"
> > + - ranges
> > + - atmel,flexcom-mode
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + flx0: flexcom@f8034000 {
> > + compatible = "atmel,sama5d2-flexcom";
> > + reg = <0xf8034000 0x200>;
> > + clocks = <&flx0_clk>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0x0 0xf8034000 0x800>;
> > + atmel,flexcom-mode = <2>;
> > +
> > + spi0: spi@400 {
> > + compatible = "atmel,at91rm9200-spi";
> > + reg = <0x400 0x200>;
> > + interrupts = <19 4 7>;
>
> as pointed - looks like a IRQ flag
>
Ok. I will change it.

> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_flx0_default>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + clocks = <&flx0_clk>;
> > + clock-names = "spi_clk";
> > + atmel,fifo-size = <32>;
> > + };
> > + };
>
>
>
> Best regards,
> Krzysztof
\
 
 \ /
  Last update: 2022-06-08 12:01    [W:0.086 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site