lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 3/4] fat: add renameat2 RENAME_EXCHANGE flag support
From
On 6/8/22 16:33, OGAWA Hirofumi wrote:
> Javier Martinez Canillas <javierm@redhat.com> writes:
>
>> + /* update ".." directory entry info */
>> + if (old_dotdot_de) {
>> + err = vfat_update_dotdot_de(new_dir, old_inode, old_dotdot_bh,
>> + old_dotdot_de);
>> + if (err)
>> + goto error_old_dotdot;
>> + drop_nlink(old_dir);
>> + inc_nlink(new_dir);
>> + }
>> +
>> + if (new_dotdot_de) {
>> + err = vfat_update_dotdot_de(old_dir, new_inode, new_dotdot_bh,
>> + new_dotdot_de);
>> + if (err)
>> + goto error_new_dotdot;
>> + drop_nlink(new_dir);
>> + inc_nlink(old_dir);
>> + }
>
> Probably, we should change the nlink only if both of dotdot update are
> succeed and different file type. Otherwise, we would have to revert the
> nlink change on error path (and can remove unnecessary update as bonus).
>

Agreed. I'll wait a few days before posting v5 in case you have more
comments on the other patches.

--
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat

\
 
 \ /
  Last update: 2022-06-08 19:10    [W:0.044 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site