Messages in this thread | | | Date | Fri, 1 Jul 2022 00:55:40 +0300 | From | Serge Semin <> | Subject | Re: [PATCH v3 05/15] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts |
| |
On Wed, Jun 29, 2022 at 07:43:34PM +0100, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The Canaan k210 apparently has a Sysnopsys Designware AXI DMA > controller, but according to the documentation & devicetree it has 6 > interrupts rather than the standard one. Support the 6 interrupt > configuration by unconditionally extending the binding to a maximum of > 8 per-channel interrupts thereby matching the number of possible > channels. > > Link: https://canaan-creative.com/wp-content/uploads/2020/03/kendryte_standalone_programming_guide_20190311144158_en.pdf #Page 51 > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > index 4324a94b26b2..e33ef22aec9c 100644 > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > @@ -34,7 +34,9 @@ properties: > - const: axidma_apb_regs > > interrupts:
> - maxItems: 1 > + description: per channel interrupts
Description is inaccurate. It's either combined or per-channel IRQs.
Other than that: Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
> + minItems: 1 > + maxItems: 8 > > clocks: > items: > -- > 2.36.1 >
| |