lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5/5] OPP: Remove custom OPP helper support
From
27.06.2022 09:06, Viresh Kumar пишет:
> Hi Dmitry,
>
> On 25-06-22, 14:42, Dmitry Osipenko wrote:
>> 31.05.2022 13:10, Viresh Kumar пишет:
>>> The only user of the custom helper is migrated to use
>>> config_regulators() interface. Remove the now unused custom OPP helper
>>> support.
>>>
>>> This cleans up _set_opp() and leaves a single code path to be used by
>>> all users.
>
>> Unfortunately we can't remove the set_opp_helper(). It's terrible that
>> this function is unused by Tegra 3d driver because it should be used.
>>
>> The patch that supposed to use the devm_pm_opp_register_set_opp_helper()
>> [1] was merged a half year ago and just today I noticed that the merged
>> code doesn't have devm_pm_opp_register_set_opp_helper() [2]. I think
>> Thierry edited my patch before applying it, perhaps there was a merge
>> conflict :/ This needs to be fixed now.
>
> As the commit log above says, we aren't removing the feature, but just
> changing the interface to cnofig_regulators(). That was the only
> special handling the drivers were required to do earlier as well, for
> which the helper interface was added.
>

Okay, but Tegra 3d driver doesn't need config_regulators(), it needs
customized set_opp() to set clock rate for both 3d engines.

\
 
 \ /
  Last update: 2022-06-27 08:11    [W:1.312 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site