Messages in this thread Patch in this message | | | Date | Sun, 26 Jun 2022 10:18:46 -0400 (EDT) | From | Julia Lawall <> | Subject | [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings |
| |
From: kernel test robot <lkp@intel.com>
for_each_available_child_of_node should have of_node_put() before return around line 697. for_each_available_child_of_node should have of_node_put() before break around line 703.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Fixes: 3973536c4560 ("spi: spi-xilinx: Updated axi-qspi controller driver") CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Julia Lawall <julia.lawall@inria.fr> ---
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS head: 59523b5c4aca0174f1f8cba2a07d3b3328b7c80e commit: 3973536c456079bf3d09e9a97bf33d29422b183f [861/1181] spi: spi-xilinx: Updated axi-qspi controller driver :::::: branch date: 5 days ago :::::: commit date: 5 months ago
Please take the patch only if it's a positive warning. Thanks!
drivers/spi/spi-xilinx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
--- a/drivers/spi/spi-xilinx.c +++ b/drivers/spi/spi-xilinx.c @@ -693,13 +693,16 @@ static int xilinx_spi_probe(struct platf if (startup_block) { ret = of_property_read_u32(nc, "reg", &cs_num); - if (ret < 0) + if (ret < 0) { + of_node_put(nc); return -EINVAL; + } } ret = of_property_read_u32(nc, "spi-rx-bus-width", &rx_bus_width); if (!ret) { xspi->rx_bus_width = rx_bus_width; + of_node_put(nc); break; } }
| |