Messages in this thread | | | Subject | Re: [PATCH v2 4/5] pinctrl: mediatek: dropping original advanced drive configuration function | From | Guodong Liu <> | Date | Sun, 26 Jun 2022 12:44:31 +0800 |
| |
-----Original Message----- From: Nícolas F. R. A. Prado <nfraprado@collabora.com> To: Guodong Liu <guodong.liu@mediatek.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Rob Herring < robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Sean Wang <sean.wang@kernel.org>, Sean Wang <sean.wang@mediatek.com>, Zhiyong Tao <zhiyong.tao@mediatek.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2 4/5] pinctrl: mediatek: dropping original advanced drive configuration function Date: Fri, 24 Jun 2022 12:08:10 -0400
Hi Guodong,
On Fri, Jun 24, 2022 at 09:36:59PM +0800, Guodong Liu wrote: > Function bias_combo getter/setters already handle all cases advanced > drive > configuration, include drive for I2C related pins.
This commit message could be improved. I suggest using the following commit message:
The bias_combo getter/setter is already able to handle advanced drive configuration, which is the reason commit 353d2ef77f2b ("dt-bindings: pinctrl: mt8192: Use generic bias instead of pull-*-adv") dropped the pull-up- adv and pull-down-adv properties from the binding. With those properties removed, there's no longer any use for the adv_pull callbacks, so drop them.
When commit info include info "commit 353d2ef77f2b", local check pathch will report "WARNING:UNKNOWN_COMMIT_IO: Unknow commit id '353d2ef77f2b'", so isn't add those commit info here. thanks! > > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks, Nícolas
| |