Messages in this thread | | | Date | Fri, 24 Jun 2022 12:08:10 -0400 | From | Nícolas F. R. A. Prado <> | Subject | Re: [PATCH v2 4/5] pinctrl: mediatek: dropping original advanced drive configuration function |
| |
Hi Guodong,
On Fri, Jun 24, 2022 at 09:36:59PM +0800, Guodong Liu wrote: > Function bias_combo getter/setters already handle all cases advanced drive > configuration, include drive for I2C related pins.
This commit message could be improved. I suggest using the following commit message:
The bias_combo getter/setter is already able to handle advanced drive configuration, which is the reason commit 353d2ef77f2b ("dt-bindings: pinctrl: mt8192: Use generic bias instead of pull-*-adv") dropped the pull-up-adv and pull-down-adv properties from the binding. With those properties removed, there's no longer any use for the adv_pull callbacks, so drop them.
> > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks, Nícolas
| |