lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name
From
On 24/06/2022 16:16, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
> named despite of the warning comment about possible backward
> compatibility issues.

Sometimes node name is exposed to user-space which depends on it. How
did you check there is no issue here?

>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++--
> arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> index a83c82c50e29..832dd85b00bd 100644
> --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> @@ -597,8 +597,8 @@ serial0: serial@10600000 {
> interrupts = <0x0 0x4c 0x4>;
> };
>
> - /* Do not change dwusb name, coded for backward compatibility */
> - usb0: dwusb@19000000 {
> + /* Node-name might need to be coded as dwusb for backward compatibility */
> + usb0: usb@19000000 {
> status = "disabled";
> compatible = "snps,dwc3";
> reg = <0x0 0x19000000 0x0 0x100000>;
> diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> index 0f37e77f5459..1520a945b7f9 100644
> --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> @@ -923,8 +923,8 @@ sata3: sata@1a800000 {
> phy-names = "sata-phy";
> };
>
> - /* Do not change dwusb name, coded for backward compatibility */
> - usb0: dwusb@19000000 {
> + /* Node-name might need to be coded as dwusb for backward compatibility */
> + usb0: usb@19000000 {
> status = "disabled";
> compatible = "snps,dwc3";
> reg = <0x0 0x19000000 0x0 0x100000>;
> @@ -933,7 +933,7 @@ usb0: dwusb@19000000 {
> dr_mode = "host";
> };
>
> - usb1: dwusb@19800000 {
> + usb1: usb@19800000 {
> status = "disabled";
> compatible = "snps,dwc3";
> reg = <0x0 0x19800000 0x0 0x100000>;


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-06-24 19:19    [W:0.145 / U:5.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site