lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm: logicvc: Fix uninitialized variable in probe
Hi Dan,

On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> The "regmap" is supposed to be initialized to NULL but it's used
> without being initialized.
>
> Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Nice catch, thanks a lot!

Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> ---
> drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
> index df1805cf0f95..0b983a33f9ff 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_drm.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
> @@ -298,7 +298,7 @@ static int logicvc_drm_probe(struct platform_device *pdev)
> struct logicvc_drm *logicvc;
> struct device *dev = &pdev->dev;
> struct drm_device *drm_dev;
> - struct regmap *regmap;
> + struct regmap *regmap = NULL;
> struct resource res;
> void __iomem *base;
> int irq;
> --
> 2.35.1
>

--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-06-24 16:38    [W:0.053 / U:10.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site