lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm: logicvc: Fix uninitialized variable in probe
On Fri, Jun 24, 2022 at 04:46:36PM +0200, Paul Kocialkowski wrote:
> Hi,
>
> On Fri 24 Jun 22, 16:37, Maxime Ripard wrote:
> > Hi,
> >
> > On Fri, Jun 24, 2022 at 04:35:25PM +0200, Paul Kocialkowski wrote:
> > > On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> > > > The "regmap" is supposed to be initialized to NULL but it's used
> > > > without being initialized.
> > > >
> > > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > > Nice catch, thanks a lot!
> > >
> > > Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> >
> > Since you have the commit rights to drm-misc, you should apply it
>
> Absolutely, I'm on my way to doing that.

Giving your Acked-by is confusing then, because it's kind of implied if
you apply it.

> Do I need to reply to the emails with a message indicating that I
> merged them or is using the tool sufficient?

Sending an email is better, dim doesn't do that

Maxime

\
 
 \ /
  Last update: 2022-06-24 17:07    [W:0.050 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site