lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 01/12] regmap-irq: Convert bool bitfields to unsigned int
On Thu, Jun 23, 2022 at 11:26:10PM +0200, Andy Shevchenko wrote:
> On Thu, Jun 23, 2022 at 11:13 PM Aidan MacDonald

> > Use 'unsigned int' for bitfields for consistency with most other
> > kernel code.

> There is no point to convert the fields you are about to remove.

> So, either don't touch them or make this patch closer to the end of the series.

It costs us nothing to convert them, this isn't a difficult or hard to
understand refactoring - the patch is fine the way it is.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-06-24 14:12    [W:0.058 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site