Messages in this thread | | | Subject | Re: [PATCH v2 01/12] regmap-irq: Convert bool bitfields to unsigned int | From | Joe Perches <> | Date | Fri, 24 Jun 2022 05:46:10 -0700 |
| |
On Fri, 2022-06-24 at 13:11 +0100, Mark Brown wrote: > On Thu, Jun 23, 2022 at 11:26:10PM +0200, Andy Shevchenko wrote: > > On Thu, Jun 23, 2022 at 11:13 PM Aidan MacDonald > > > > Use 'unsigned int' for bitfields for consistency with most other > > > kernel code. > > > There is no point to convert the fields you are about to remove. > > > So, either don't touch them or make this patch closer to the end of the series. > > It costs us nothing to convert them, this isn't a difficult or hard to > understand refactoring - the patch is fine the way it is.
Modulo the defects that might be introduced if an overflow occurs.
struct foo { unsigned int a:1; bool b:1; }
Assign a non-zero int without bit 0 set to each and see if a and b differ.
| |