lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/10] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry
On Fri, Jun 24, 2022 at 11:54:58AM +0200, Krzysztof Kozlowski wrote:
> > + microchip,data-ready-hiz:
> > + description:
> > + Data Ready Pin Inactive State Control bit
>
> "Bit" of what? Do not describe the programming model but the actual feature.
>

You are right. I will remove "bit".

> > + true = The DR pin state is high-impedance when data are NOT ready
> > + false = The DR pin state is a logic high when data are NOT ready
> > + type: boolean
> > + default: false
>
> You do not need default for bools.

OK
>
> > +
> > microchip,device-addr:
> > description: Device address when multiple MCP3911 chips are present on the same SPI bus.
> > $ref: /schemas/types.yaml#/definitions/uint32
>
>
> Best regards,
> Krzysztof

Thanks,
Marcus Folkesson


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-06-24 14:10    [W:0.056 / U:22.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site