lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [net-next: PATCH 11/12] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs
On Mon, Jun 20, 2022 at 05:02:24PM +0200, Marcin Wojtas wrote:
> In order to support both ACPI and DT, modify the generic
> DSA code to use device_/fwnode_ equivalent routines.
> No functional change is introduced by this patch.

...

> int err;
>
> - if (!np && !pdata)
> + if (!fwnode && !pdata)
> return -EINVAL;

Sounds like redundant check

if (pdata)
...
else
compat_info = ...
if (!compat_info)
return -EINVAL

?

> - if (np)
> - compat_info = of_device_get_match_data(dev);
> + if (fwnode)
> + compat_info = device_get_match_data(dev);
>
> if (pdata) {

Missed 'else' even in the original code (see above)?

> compat_info = pdata_device_get_match_data(dev);


--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-06-20 20:04    [W:1.370 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site