Messages in this thread | | | Subject | Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind | From | "Zhengbin (OSKernel)" <> | Date | Thu, 16 Jun 2022 14:10:17 +0800 |
| |
On 2022/6/10 6:22, Sebastian Reichel wrote: > Hi, > > On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote: >> ab8500_charger_bind misses destroy_workqueue in error path, >> this patch fixes that. >> >> Signed-off-by: Zheng Bin <zhengbin13@huawei.com> >> --- > LGTM, but adding Linus to Cc and waiting a bit to give him time to > react. > > -- Sebastian ping > >> drivers/power/supply/ab8500_charger.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c >> index d04d087caa50..a5d055a628e7 100644 >> --- a/drivers/power/supply/ab8500_charger.c >> +++ b/drivers/power/supply/ab8500_charger.c >> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev) >> ret = component_bind_all(dev, di); >> if (ret) { >> dev_err(dev, "can't bind component devices\n"); >> + destroy_workqueue(di->charger_wq); >> return ret; >> } >> >> -- >> 2.31.1 >>
| |