lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind
Hi,

On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> ab8500_charger_bind misses destroy_workqueue in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---

LGTM, but adding Linus to Cc and waiting a bit to give him time to
react.

-- Sebastian

> drivers/power/supply/ab8500_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index d04d087caa50..a5d055a628e7 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
> ret = component_bind_all(dev, di);
> if (ret) {
> dev_err(dev, "can't bind component devices\n");
> + destroy_workqueue(di->charger_wq);
> return ret;
> }
>
> --
> 2.31.1
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-06-10 00:24    [W:0.102 / U:2.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site