lkml.org 
[lkml]   [2022]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [net-next PATCH] net: ethernet: stmicro: stmmac: permit MTU change with interface up
On Wed, Jun 15, 2022 at 07:55:07PM -0700, Jakub Kicinski wrote:
> On Wed, 15 Jun 2022 00:41:41 +0200 Christian 'Ansuel' Marangi wrote:
> > + if (netif_running(dev)) {
> > + netdev_dbg(priv->dev, "restarting interface to change its MTU\n");
> > + stmmac_release(dev);
> > +
> > + stmmac_open(dev);
> > + stmmac_set_filter(priv, priv->hw, dev);
>
> What if stmmac_open() fails because the memory is low or is fragmented?
>
> You'd need to invest more effort into this change and try to allocate
> all the resources before shutting the device down.

Well what I'm doing here is following what is done with other similar
function in stmmac. For example the reinit_queues and reinit_ringparam
doesn't do such check.

But ok you are right, will see a good solution to change stmmac_open to
preallocate the buffers.

--
Ansuel

\
 
 \ /
  Last update: 2022-06-16 14:06    [W:0.529 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site