lkml.org 
[lkml]   [2022]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [net-next PATCH] net: ethernet: stmicro: stmmac: permit MTU change with interface up
On Wed, 15 Jun 2022 00:41:41 +0200 Christian 'Ansuel' Marangi wrote:
> + if (netif_running(dev)) {
> + netdev_dbg(priv->dev, "restarting interface to change its MTU\n");
> + stmmac_release(dev);
> +
> + stmmac_open(dev);
> + stmmac_set_filter(priv, priv->hw, dev);

What if stmmac_open() fails because the memory is low or is fragmented?

You'd need to invest more effort into this change and try to allocate
all the resources before shutting the device down.

\
 
 \ /
  Last update: 2022-06-16 04:57    [W:0.038 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site