lkml.org 
[lkml]   [2022]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] mach-ux500: (pm_domain) Add missing of_node_put()
Date
In ux500_pm_domains_init(), of_find_matching_node() will return a
node pointer with refcount incremented. We should use of_node_put()
in fail path or when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
---
changelog:

v2: use real name for Sob
v1: fix missing bug

arch/arm/mach-ux500/pm_domains.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-ux500/pm_domains.c b/arch/arm/mach-ux500/pm_domains.c
index 427b9ac4af6c..81926b197e51 100644
--- a/arch/arm/mach-ux500/pm_domains.c
+++ b/arch/arm/mach-ux500/pm_domains.c
@@ -65,8 +65,10 @@ int __init ux500_pm_domains_init(void)
return -ENODEV;

genpd_data = kzalloc(sizeof(*genpd_data), GFP_KERNEL);
- if (!genpd_data)
+ if (!genpd_data) {
+ of_node_put(np);
return -ENOMEM;
+ }

genpd_data->domains = ux500_pm_domains;
genpd_data->num_domains = ARRAY_SIZE(ux500_pm_domains);
@@ -75,5 +77,6 @@ int __init ux500_pm_domains_init(void)
pm_genpd_init(ux500_pm_domains[i], NULL, false);

of_genpd_add_provider_onecell(np, genpd_data);
+ of_node_put(np);
return 0;
}
--
2.25.1
\
 
 \ /
  Last update: 2022-06-16 06:18    [W:0.029 / U:1.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site