Messages in this thread Patch in this message | | | From | heliang <> | Subject | [PATCH] bus: mvebu-mbus: Add missing of_node_put in fail path | Date | Wed, 15 Jun 2022 15:24:07 +0800 |
| |
In mvebu_mbus_dt_init, of_find_matching_node_and_match() and of_find_node_by_phandle() will return node pointer with refcounter incremented. We should use of_node_put in fail path.
Signed-off-by: heliang <windhl@126.com> --- drivers/bus/mvebu-mbus.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c index db612045616f..7b16ede5097f 100644 --- a/drivers/bus/mvebu-mbus.c +++ b/drivers/bus/mvebu-mbus.c @@ -1327,22 +1327,28 @@ int __init mvebu_mbus_dt_init(bool is_coherent) prop = of_get_property(np, "controller", NULL); if (!prop) { + of_node_put(np); pr_err("required 'controller' property missing\n"); return -EINVAL; } controller = of_find_node_by_phandle(be32_to_cpup(prop)); if (!controller) { + of_node_put(np); pr_err("could not find an 'mbus-controller' node\n"); return -ENODEV; } if (of_address_to_resource(controller, 0, &mbuswins_res)) { + of_node_put(np); + of_node_put(controller); pr_err("cannot get MBUS register address\n"); return -EINVAL; } if (of_address_to_resource(controller, 1, &sdramwins_res)) { + of_node_put(np); + of_node_put(controller); pr_err("cannot get SDRAM register address\n"); return -EINVAL; } -- 2.25.1
| |