lkml.org 
[lkml]   [2022]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WRF_cmd
On Mon, Jun 13, 2022 at 07:07:33PM -0700, daniel watson wrote:
> From: Daniel Watson <ozzloy@challenge-bot.com>
>
> name the function rtw_IOL_append_WRF_cmd and call it directly,
^^^^^^^^
Where is the first part of the sentence?

> instead of using wrapper macro
>
> delete wrapper macro, which is not needed
>
> NOTE: code compiles, not tested on hardware
>
> Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>
>
> staging: r8188eu: remove leading '_' on _rtw_IOL_append_WRF_cmd
>
> call rtw_IOL_append_WRF_cmd directly instead of using wrapper macro

This is a better commit message but use a capital C "Call".

> delete wrapper macro, which is not needed
>
> NOTE: code compiles, not tested on hardware
>
> Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>

You have the commit message twice.

regards,
dan carpenter

\
 
 \ /
  Last update: 2022-06-14 16:49    [W:0.143 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site