Messages in this thread | | | Date | Tue, 14 Jun 2022 17:42:45 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WB_cmd |
| |
On Mon, Jun 13, 2022 at 07:07:30PM -0700, daniel watson wrote: > From: Daniel Watson <ozzloy@challenge-bot.com> > > name the function rtw_IOL_append_WB_cmd and call it directly, > instead of using wrapper macro > > delete wrapper macro, which is not needed > > NOTE: code compiles, not tested on hardware
Don't put this kind of comment in the commit message. Put it under the --- cut off line.
> > Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com> > --- ^^^ Here.
You don't even really need to tell us that you compiled the code, because we take that as a given.
regards, dan carpenter
| |