Messages in this thread | | | Date | Sat, 11 Jun 2022 23:03:24 +0300 | Subject | Re: [PATCH] arm64: dts: qcom: qcs404: fix default pinctrl settings for blsp1_spi1 | From | Andrey Konovalov <> |
| |
On 6/11/22 22:57, Andrey Konovalov wrote: > The current settings refer to "blsp_spi1" function which isn't defined. > For this reason an attempt to enable blsp1_spi1 interface results in > the probe failure below: > > [ 3.492900] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table > [ 3.502460] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table > [ 3.517725] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table > [ 3.532998] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table > [ 3.548277] spi_qup: probe of 78b6000.spi failed with error -22 > > Fix this by making the functions used in qcs404.dtsi to match the contents > of drivers/pinctrl/qcom/pinctrl-qcs404.c.
... and Documentation/devicetree/bindings/pinctrl/qcom,qcs404-pinctrl.txt.
> > Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org> > --- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi > index d912166b7552..0d9e1f19aa67 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > @@ -669,8 +669,25 @@ blsp1_spi0_default: blsp1-spi0-default { > }; > > blsp1_spi1_default: blsp1-spi1-default { > - pins = "gpio22", "gpio23", "gpio24", "gpio25"; > - function = "blsp_spi1"; > + mosi { > + pins = "gpio22"; > + function = "blsp_spi_mosi_a1"; > + }; > + > + miso { > + pins = "gpio23"; > + function = "blsp_spi_miso_a1"; > + }; > + > + cs_n { > + pins = "gpio24"; > + function = "blsp_spi_cs_n_a1"; > + }; > + > + clk { > + pins = "gpio25"; > + function = "blsp_spi_clk_a1"; > + }; > }; > > blsp1_spi2_default: blsp1-spi2-default {
| |