lkml.org 
[lkml]   [2022]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: dts: qcom: qcs404: fix default pinctrl settings for blsp1_spi1
On 30-06-22, 09:18, Bjorn Andersson wrote:
> On Wed 22 Jun 00:18 CDT 2022, Vinod Koul wrote:
>
> > On 11-06-22, 22:57, Andrey Konovalov wrote:
> > > The current settings refer to "blsp_spi1" function which isn't defined.
> > > For this reason an attempt to enable blsp1_spi1 interface results in
> > > the probe failure below:
> > >
> > > [ 3.492900] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table
> > > [ 3.502460] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table
> > > [ 3.517725] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table
> > > [ 3.532998] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table
> > > [ 3.548277] spi_qup: probe of 78b6000.spi failed with error -22
> > >
> > > Fix this by making the functions used in qcs404.dtsi to match the contents
> > > of drivers/pinctrl/qcom/pinctrl-qcs404.c.
> >
> > Right, I cannot find blsp_spi1 which is the only one which is missing,
> > not sure why...
> >
> > Bjorn do you recall why SPI1 is treated differently...
>
> Looking at the available pinctrl functions, I believe that blsp_spi1 has
> two possible mux options; identified b y blsp_spi_*_a1 and
> blsp_spi_*_b1.

Yes, so are we good to merge this?

--
~Vinod

\
 
 \ /
  Last update: 2022-07-01 06:42    [W:0.043 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site