lkml.org 
[lkml]   [2022]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] RDMA/cm: fix cond_no_effect.cocci warnings
Date
This was found by coccicheck:

./drivers/infiniband/core/cm.c:685:7-9: WARNING: possible condition with no effect (if == else).

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/infiniband/core/cm.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
index 1c107d6d03b9..bb6a2b6b9657 100644
--- a/drivers/infiniband/core/cm.c
+++ b/drivers/infiniband/core/cm.c
@@ -676,14 +676,9 @@ static struct cm_id_private *cm_find_listen(struct ib_device *device,
refcount_inc(&cm_id_priv->refcount);
return cm_id_priv;
}
- if (device < cm_id_priv->id.device)
+ if (device < cm_id_priv->id.device ||
+ be64_lt(service_id, cm_id_priv->id.service_id))
node = node->rb_left;
- else if (device > cm_id_priv->id.device)
- node = node->rb_right;
- else if (be64_lt(service_id, cm_id_priv->id.service_id))
- node = node->rb_left;
- else if (be64_gt(service_id, cm_id_priv->id.service_id))
- node = node->rb_right;
else
node = node->rb_right;
}
--
2.20.1.7.g153144c
\
 
 \ /
  Last update: 2022-06-10 11:46    [W:0.085 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site