Messages in this thread Patch in this message | | | From | Denis OSTERLAND-HEIM <> | Subject | RE: [PATCH v1 1/1] leds: core: Refactor led_update_brightness() to use standard pattern | Date | Fri, 10 Jun 2022 07:08:48 +0200 (CEST) |
| |
LGTM
Acked-by: Denis Osterland-Heim <denis.osterland@diehl.com>
-----Original Message----- From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Sent: Thursday, June 9, 2022 6:23 PM To: Denis OSTERLAND-HEIM <denis.osterland@diehl.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-leds@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Pavel Machek <pavel@ucw.cz> Subject: [PATCH v1 1/1] leds: core: Refactor led_update_brightness() to use standard pattern
The standard conditional pattern is to check for errors first and bail out if any. Refactor led_update_brightness() accordingly.
While at it, drop unneeded assignment and return 0 unconditionally on success.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/leds/led-core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index 4a97cb745788..96a2817712e5 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -304,17 +304,17 @@ EXPORT_SYMBOL_GPL(led_set_brightness_sync); int led_update_brightness(struct led_classdev *led_cdev) { - int ret = 0; + int ret; if (led_cdev->brightness_get) { ret = led_cdev->brightness_get(led_cdev); - if (ret >= 0) { - led_cdev->brightness = ret; - return 0; - } + if (ret < 0) + return ret; + + led_cdev->brightness = ret; } - return ret; + return 0; } EXPORT_SYMBOL_GPL(led_update_brightness); -- 2.35.1[unhandled content-type:application/x-pkcs7-signature] | |