Messages in this thread | | | Date | Mon, 9 May 2022 12:27:59 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] pinctrl: stm32: Unshadow np variable in stm32_pctl_probe() |
| |
On Mon, May 09, 2022 at 09:39:57AM +0200, Fabien DESSENNE wrote: > Hi Andy > > > Thank you for the patch. > > Will this patch be applied in Linus pinctrl tree, or in the gpio-intel tree > before being merged (linux-next) in the pinctrl tree?
I believe the pin control tree is a primary here, while applying to GPIO tree won't harm. But I maintain neither of them :-)
> On 07/05/2022 12:22, Andy Shevchenko wrote: > > The np variable is used globally for stm32_pctl_probe() and in one of > > its code branches. cppcheck is not happy with that: > > > > pinctrl-stm32.c:1530:23: warning: Local variable 'np' shadows outer variable [shadowVariable] > > > > Instead of simply renaming one of the variables convert some code to > > use a device pointer directly. > > > > Fixes: bb949ed9b16b ("pinctrl: stm32: Switch to use for_each_gpiochip_node() helper") > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Fabien Dessenne <fabien.dessenne@foss.st.com>
Thanks!
-- With Best Regards, Andy Shevchenko
| |