Messages in this thread | | | From | Linus Walleij <> | Date | Sat, 14 May 2022 01:14:10 +0200 | Subject | Re: [PATCH v1 1/1] pinctrl: stm32: Unshadow np variable in stm32_pctl_probe() |
| |
On Sat, May 7, 2022 at 12:23 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> The np variable is used globally for stm32_pctl_probe() and in one of > its code branches. cppcheck is not happy with that: > > pinctrl-stm32.c:1530:23: warning: Local variable 'np' shadows outer variable [shadowVariable] > > Instead of simply renaming one of the variables convert some code to > use a device pointer directly. > > Fixes: bb949ed9b16b ("pinctrl: stm32: Switch to use for_each_gpiochip_node() helper") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied!
Yours, Linus Walleij
| |