lkml.org 
[lkml]   [2022]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] staging: rtl8712: fix uninit-value in usb_read8() and friends
From
Hi Wang,

On 5/6/22 06:15, Wang Cheng wrote:
> When r8712_usbctrl_vendorreq() returns negative, 'data' in
> usb_read{8,16,32} will not be initialized.

[code snip]

> + status = r8712_usbctrl_vendorreq(intfpriv, request, wvalue, index,
> + &data, len, requesttype);
> + if (status < 0)
> + return 0;
> return le32_to_cpu(data);
> }
>

Why do you believe that 0 is not valid register value? And if it's
possible then how you can identify an error?




With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2022-05-06 09:25    [W:0.105 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site