lkml.org 
[lkml]   [2022]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] staging: rtl8712: fix uninit-value in usb_read8() and friends
Setting "data = 0" will silence the KMSAN warnings but it doesn't fix
the bug which is that r8712_usbctrl_vendorreq() treats partial reads
as success.

The usb_control_msg() returns negatives on total failure and it returns
small positives on partial failure. So take the code that I gave you
before and put that into r8712_usbctrl_vendorreq(). That's patch 1.
These patches become 2 and 3.

status = usb_control_msg();
if (status < 0)
goto free;
if (status != len) {
status = -EREMOTEIO;
goto free;
}
if (requesttype == 0x01)
memcpy(pdata, pIo_buf, status);

regards,
dan carpenter

\
 
 \ /
  Last update: 2022-05-06 09:12    [W:0.096 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site