Messages in this thread Patch in this message | | | From | Baoquan He <> | Subject | [PATCH] sh: cast away __iomem to remove sparse warning | Date | Sat, 7 May 2022 09:34:11 +0800 |
| |
LKP reported a sparse warning in arch/sh/kernel/crash_dump.c during a kdump patchset reviewing: https://lore.kernel.org/all/202204082128.JKXXDGpa-lkp@intel.com/T/#u
../arch/sh/kernel/crash_dump.c:23:36: sparse: warning: incorrect type in argument 1 (different address spaces) ../arch/sh/kernel/crash_dump.c:23:36: sparse: expected void const *addr ../arch/sh/kernel/crash_dump.c:23:36: sparse: got void [noderef] __iomem *
This warning happened when __iomem pointer is passed into fucntion which doesn't expect it. Casting away the __iomem can fix it.
Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Baoquan He <bhe@redhat.com> --- arch/sh/kernel/crash_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/kernel/crash_dump.c b/arch/sh/kernel/crash_dump.c index 19ce6a950aac..52d1d54eb6b1 100644 --- a/arch/sh/kernel/crash_dump.c +++ b/arch/sh/kernel/crash_dump.c @@ -20,7 +20,7 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn, return 0; vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE); - csize = copy_to_iter(vaddr + offset, csize, iter); + csize = copy_to_iter((const void __force *)vaddr + offset, csize, iter); iounmap(vaddr); return csize; -- 2.34.1
| |