lkml.org 
[lkml]   [2022]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ARM: dove: fix returnvar.cocci warnings
From
On 5/3/22 00:21, Arnd Bergmann wrote:
> On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@intel.com> wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161
>>
>> Remove unneeded variable used to store return value.
>>
>> Generated by: scripts/coccinelle/misc/returnvar.cocci
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
> I checked the patch, and unfortunately it is wrong, the current code
> needs to stay.
> The problem is the SET_DMA_ERRATA() macro that accesses the
> local 'errata' variable.

0day folks, do we have humans looking over these before they're going
out to the list? If not, can we add some? If so, can the humans get a
little more discerning? ;)

\
 
 \ /
  Last update: 2022-05-05 18:32    [W:0.118 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site